Skip to content

bug_fix#7

Open
DaichiSaito wants to merge 3 commits intoDaichiSaito:bugfrom
MiyazakiAkari:bug_fix
Open

bug_fix#7
DaichiSaito wants to merge 3 commits intoDaichiSaito:bugfrom
MiyazakiAkari:bug_fix

Conversation

@DaichiSaito
Copy link
Copy Markdown
Owner

No description provided.

Comment on lines +10 to +12
if !current_user.nil?
redirect_to new_session_path, alert: 'ログインしてください' unless current_user
end
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここはどういう意図で修正しましたか?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless current_userがエラーの原因なのかなと思って自分が使い慣れているif文に書き換えたつもりだったのですがunless current_userを消し忘れてしまいました

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど!では消してもらえると!

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

というかこれそもそもif文に書き換える必要はなくないですかね??

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この部分の修正はまるっと元に戻していいと思ったんですがどうでしょう?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そうですね、書き換える必要はないのでもとに戻します!

Copy link
Copy Markdown
Owner Author

@DaichiSaito DaichiSaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants